Re: [PATCH 07/14 re-post] syscalls: addARCH_COMPAT_SYSCALL_DEFINE()

[Frederic Weisbecker]

On Thu, Mar 18, 2010 at 02:29:09PM -0400, Jason Baron wrote:
> 
> Re-post due to missing macro parameter. interdiff:
> 
> diff -u b/include/linux/syscalls.h b/include/linux/syscalls.h
> --- b/include/linux/syscalls.h
> +++ b/include/linux/syscalls.h
> @@ -241,7 +241,7 @@
>  	SYSCALL_METADATA(syscall, compat_sys_##sname, x);	\
>  	asmlinkage long syscall(__SC_DECL##x(__VA_ARGS__))
>  #else
> -#define COMPAT_SYSCALL_DEFINEx(x, sname, ...)			\
> +#define COMPAT_SYSCALL_DEFINEx(x, syscall, sname, ...)		\
>  	asmlinkage long syscall(__SC_DECL##x(__VA_ARGS__))
>  #endif
> 
> --------------------------------------------------------
> 
> Add ARCH_COMPAT_SYSCALL_DEFINE#N() macro which prepends "sys32_" to
> arch specific compat syscall names. Identifies the 'compat' syscalls.
> 
> Signed-off-by: Jason Baron <jbaron@xxxxxxxxxx>
> ---
>  include/linux/syscalls.h |   50 ++++++++++++++++++++++++++++++++++-----------
>  1 files changed, 38 insertions(+), 12 deletions(-)
> 
> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
> index e601985..b5f66dc 100644
> --- a/include/linux/syscalls.h
> +++ b/include/linux/syscalls.h
> @@ -141,7 +141,7 @@ struct perf_event_attr;
>  	  __attribute__((__aligned__(4)))				\
>  	  __attribute__((section("_ftrace_events")))			\
>  	  event_enter_##sname = {					\
> -		.name                   = "sys_enter"#sname,		\
> +		.name                   = "enter_"#sname,		\



BTW, removing the sys_ prefix would be a cool change but I'd prefer
we limit the ABI changes if possible (although I must confess
the ABI is going to be seriously damaged if we support user pointer
deref later :p)

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/