[patch] usb/oxu210hp: release spinlock on error path

From: Dan Carpenter
Date: Mon Mar 29 2010 - 05:01:45 EST


Smatch complained about this missing spinlock.

Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
---
Compile tested only. :/

diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c
index 50f57f4..e62b30b 100644
--- a/drivers/usb/host/oxu210hp-hcd.c
+++ b/drivers/usb/host/oxu210hp-hcd.c
@@ -660,13 +660,13 @@ static struct ehci_qh *oxu_qh_alloc(struct oxu_hcd *oxu)
if (qh->dummy == NULL) {
oxu_dbg(oxu, "no dummy td\n");
oxu->qh_used[i] = 0;
-
- return NULL;
+ qh = NULL;
+ goto unlock;
}

oxu->qh_used[i] = 1;
}
-
+unlock:
spin_unlock(&oxu->mem_lock);

return qh;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/