Re: [PATCH 0/3] perf/core, x86: unify perfctr bitmasks

[Stephane Eranian]

On Tue, Mar 30, 2010 at 5:11 PM, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
> On Tue, Mar 30, 2010 at 05:00:55PM +0200, Peter Zijlstra wrote:
>> On Tue, 2010-03-30 at 15:53 +0200, Stephane Eranian wrote:
>> > > So, there are some ARCH_PERFMON_EVENTSEL_* masks that are Intel only,
>> > > which is true for ARCH_PERFMON_EVENTSEL_ANY. And indead, the code
>> > > should be checked for this. ARCH_PERFMON_EVENTSEL_ANY is always
>> > > cleared on AMD cpus, so this code is ok. Actually the bit is cleared
>> >
>> > Until AMD uses that bit too and you won't notice this test. This is a security
>> > check specific to Intel and it should be in an Intel-specific function.
>> >
>> > > for *all* cpus in x86_pmu_raw_event(), the code was and is broken for
>> > > this.
>> > >
>> > Yes, needs to be authorized for any perfmon v3 and later revisions.
>>
>> So how about something like this on top of Robert's patches?
>>
> [...]
>
> Looks good for me! Thanks Peter!
>
Looks better. Thanks.

Acked-by: Stephane Eranian <eranian@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/