linux-next: build warning after merge of the cifs tree

From: Stephen Rothwell
Date: Wed Mar 31 2010 - 20:51:31 EST


Hi Steve,

After merging the cifs tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

fs/cifs/cifssmb.c: In function 'CIFSSMBWrite':
fs/cifs/cifssmb.c:1516: warning: suggest explicit braces to avoid ambiguous 'else'

Introduced by commit 5702f749ee6645f70412cfe6408503a735366ffe ("cifs:
initialize nbytes at the beginning of CIFSSMBWrite()").

The cFYI() macro that is invoked in the (unbraced) if clause contains an
if statement ... so this warning actually indicates a bug. Those
debugging macros look like a real mess ...

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature