Re: [PATCH] rcu: don't call rcu_preempt_note_context_switch() inrcu_check_callbacks()

From: Lai Jiangshan
Date: Thu Apr 01 2010 - 03:23:55 EST


Paul E. McKenney wrote:
> Possibly by moving the clearing of RCU_READ_UNLOCK_NEED_QS to
> rcu_preempt_check_callbacks()

current rcu_preempt_check_callbacks() already has code to
clear RCU_READ_UNLOCK_NEED_QS.

> -- or to rcu_preempt_qs(). The latter is in
> some sense cleaner, but higher overhead and probably unnecessary. Hmmm...
> Alternatively, require that all callers to rcu_preempt_qs() disable
> irqs. This affects only one callsite, which has a local_irq_disable()
> immediately following anyway. ;-)
>
> Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/