Re: [PATCH 2/3] can: add support for Janz VMOD-ICAN3 IntelligentCAN module
From: Andrew Morton
Date: Thu Apr 01 2010 - 16:04:17 EST
On Mon, 29 Mar 2010 09:58:51 -0700
"Ira W. Snyder" <iws@xxxxxxxxxxxxxxxx> wrote:
> The Janz VMOD-ICAN3 is a MODULbus daughterboard which fits onto any
> MODULbus carrier board. It is an intelligent CAN controller with a
> microcontroller and associated firmware.
A neat-looking driver.
> + spin_lock_irqsave(&mod->lock, flags);
It does this rather a lot. it seems to be doing quite a lot of work
under that lock, too - quite a lot of memcpy_toio(), other stuff.
Is there potential here to disable interrupt for too long? Not
possible to use spin_lock_bh() here?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/