Re: [Kgdb-bugreport] [PATCH 4/5] kgdb: Use atomic operators whichusebarriers

From: Linus Torvalds
Date: Fri Apr 02 2010 - 15:51:47 EST




On Fri, 2 Apr 2010, Jason Wessel wrote:
>
> Here is the revised patch, which is going into the kgdb-fixes branch.

Yeah, this patch I have no issues with.

Except:

> From: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
> Subject: [PATCH] kgdb: Use atomic operators which use barriers
>
> The cpu_relax() does not mandate that there is an smp memory barrier.
> As a result on the arm smp architecture the kernel debugger can hang
> on entry from time to time, as shown by the kgdb regression tests.

Now your changelog makes no sense any more.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/