Re: [PATCH] power/ds2782: fix clientdata on removal
From: Wolfram Sang
Date: Sun Apr 04 2010 - 10:13:50 EST
On Thu, Apr 01, 2010 at 02:40:21PM +0400, Anton Vorontsov wrote:
> On Thu, Apr 01, 2010 at 12:27:44PM +0200, Wolfram Sang wrote:
> > Probably due to a copy & paste bug, clientdata was set again to the data
> > structure (which is freed immediately afterwards) when it should be
> > NULLed. Just remove the calls as the i2c-core does this automatically
> > now.
> > Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> > Cc: Ryan Mallon <ryan@xxxxxxxxxxxxxxxx>
> > Cc: Hans Verkuil <hverkuil@xxxxxxxxx>
> > Cc: Anton Vorontsov <cbouatmailru@xxxxxxxxx>
> > Cc: Jean Delvare <khali@xxxxxxxxxxxx>
> > ---
> > Anton: If it is okay with you, I think this should go via the I2C-tree to
> > ensure it comes after the needed modification of the i2c-core.
> Sure thing.
> Acked-by: Anton Vorontsov <cbouatmailru@xxxxxxxxx>
Sorry, I misunderstood Jean. Would be nice if you could pick it up. Sorry for
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Description: Digital signature