Re: [PATCH] Swap including order of util.h and string.h ofutil/string.c

From: Arnaldo Carvalho de Melo
Date: Sun Apr 04 2010 - 19:23:51 EST

Em Sun, Apr 04, 2010 at 04:34:43PM +0200, Frederic Weisbecker escreveu:
> On Sun, Apr 04, 2010 at 05:13:18PM +0900, Hitoshi Mitake wrote:
> > Current util/string.c includes headers in this order: string.h, util.h
> > But this causes build error because __USE_GNU definition
> > is needed for strndup() definition like this,
> > % make -j
> > touch
> > CC util/string.o
> > cc1: warnings being treated as errors
> > util/string.c: In function âargv_splitâ:
> > util/string.c:171: error: implicit declaration of function âstrndupâ
> > util/string.c:171: error: incompatible implicit declaration of built-in function âstrndupâ
> Thanks, I've queued it as I have the same problem and I'm
> about to send a perf/core queue.

Sorry about that and thanks for queueing it up, keeping this tempo of
getting patches queued up and pushed up upstream for perf is really nice
inasmuch as we keep it sane, and so far I think it is really being
excellent! :-)

- Arnaldo
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at