Bad watchdog ioctl definitions
From: James Hogan
Date: Mon Apr 05 2010 - 05:39:43 EST
I've noticed that some of the ioctl definitions in
include/linux/watchdog.h are incorrect, for example:
#define WDIOC_SETOPTIONS _IOR(WATCHDOG_IOCTL_BASE, 4, int)
This is a write ioctl so should be _IOW
#define WDIOC_KEEPALIVE _IOR(WATCHDOG_IOCTL_BASE, 5, int)
I think this should just be _IO since the argument is ignored anyway
>From a quick grep, mpcore_wdt appears to be the only watchdog driver
in drivers/watchdog that uses _IOC_DIR on the ioctl number, which
breaks the SETOPTIONS ioctl on this driver.
Is it usually even possible to change ioctl numbers for compatibility?
What's the usual process?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/