Re: [patch] dma-debug: off by one issue

From: Joerg Roedel
Date: Mon Apr 05 2010 - 10:02:26 EST


On Mon, Apr 05, 2010 at 03:53:30PM +0300, Dan Carpenter wrote:
> On Sat, Apr 03, 2010 at 10:47:17PM +0200, Joerg Roedel wrote:

> > The character is already reserved by the user-to-kernel copy earlier in
> > the function.
>
> Yes, but the original code requires more code reading to audit. Let's
> change the commit message to say that it's a clean up patch.

In this case its better to remove the

current_driver_name[i] = 0;

line just after the loop.

Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/