Re: [PATCH 4/5] blkdev: add discard payload flag

From: Dmitry Monakhov
Date: Tue Apr 06 2010 - 04:30:13 EST


Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:

> On Wed, Mar 24, 2010 at 08:33:07PM +0300, Dmitry Monakhov wrote:
>> Not all implementations require discard bio to be filled with one-sector
>> sized payload. Let's allocate payload only when necessary.
>
> Neither this nor the next one are really needed as I have some patches
> pending to move the payload allocation into the low level drivers.
Ok good to know. As soon as i understand on low level you know how
many memory you actually need to store a request range.
BTW Do you know any drivers which max_discard_sectors contains some
restricted value? Because my 5'th patch was aimed to optimize the case
where discard request must being spitted to several bio-s.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/