Re: [GIT PULL] break implicit percpu.h -> slab.h dependency

From: Ingo Molnar
Date: Tue Apr 06 2010 - 05:25:46 EST

* Tejun Heo <tj@xxxxxxxxxx> wrote:

> git:// slabh
> This is rather unusual pull request at this stage in -rc cycles but
> given the mostly trivial nature and massive size of this change, I
> think it would be beneficial to merge this while the tree isn't
> changing too rapidly and as early as possible so that further
> breakages aren't introduced.

FYI, -tip testing found a build breakage with your changes:

drivers/base/node.c:373: error: implicit declaration of function 'kmalloc'
drivers/base/node.c:377: error: implicit declaration of function 'kfree'

The fix is below. Since my first test today triggered a build failure i'd
expect there to be more - i'll send all subsequent fixes to this thread.



Index: linux2/drivers/base/node.c
--- linux2.orig/drivers/base/node.c
+++ linux2/drivers/base/node.c
@@ -16,6 +16,7 @@
#include <linux/device.h>
#include <linux/swap.h>
#include <linux/gfp.h>
+#include <linux/slab.h>

static struct sysdev_class_attribute *node_state_attrs[];

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at