Re: [GIT PULL] break implicit percpu.h -> slab.h dependency

From: Ingo Molnar
Date: Tue Apr 06 2010 - 05:50:40 EST



* Tejun Heo <tj@xxxxxxxxxx> wrote:

> Hello, Ingo.
>
> On 04/06/2010 06:25 PM, Ingo Molnar wrote:
> > FYI, -tip testing found a build breakage with your changes:
> >
> > drivers/base/node.c:373: error: implicit declaration of function 'kmalloc'
> > drivers/base/node.c:377: error: implicit declaration of function 'kfree'
>
> These are NODEMASK_ALLOC() and NODEMASK_FREE() macros which become
> kmalloc/kfree() iff NODES_SHIFT > 8. I'll grep for these macros and
> commit a proper fix.
>
> > The fix is below. Since my first test today triggered a build failure i'd
> > expect there to be more - i'll send all subsequent fixes to this thread.
>
> Thanks. Much appreciated.

It's looking pretty good so far with about a dozen tests passed. Thanks for
doing this transition so carefully!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/