Re: [PATCH 4/7] hvc_console: Fix race between hvc_close and hvc_remove

From: Sachin Sant
Date: Tue Apr 06 2010 - 08:27:56 EST

Anton Blanchard wrote:
The patch below changes things to call tty_kref_put once for every
hvc_close call, and with that my machine boots fine.

Signed-off-by: Anton Blanchard <anton@xxxxxxxxx>
Works for me. Thanks Anton.


diff --git a/drivers/char/hvc_console.c b/drivers/char/hvc_console.c
index d3890e8..35cca4c 100644
--- a/drivers/char/hvc_console.c
+++ b/drivers/char/hvc_console.c
@@ -368,16 +368,12 @@ static void hvc_close(struct tty_struct *tty, struct file * filp)
hp = tty->driver_data;

spin_lock_irqsave(&hp->lock, flags);
- tty_kref_get(tty);

if (--hp->count == 0) {
/* We are done with the tty pointer now. */
hp->tty = NULL;
spin_unlock_irqrestore(&hp->lock, flags);

- /* Put the ref obtained in hvc_open() */
- tty_kref_put(tty);
if (hp->ops->notifier_del)
hp->ops->notifier_del(hp, hp->data);


Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at