Re: [PATCH]: REPOST cleanup debug message in init_kstat_irqs()

From: Prarit Bhargava
Date: Tue Apr 06 2010 - 09:49:44 EST

Whoops... Subject should have been REPOST cleanup debug message in irq_to_desc_alloc_node()

Sorry 'bout that.


Prarit Bhargava wrote:
[Sending to a wider audience this time, cc'ing Andrew and Ingo directly]

Clean up debug messages in irq_to_desc_alloc_node().

This debug message can result in valid output like

alloc irq_desc for 73 on node -1

which looks like alot like an error message.

This debug statement has been in the kernel for about a year, so I think it is
safe to remove it and report the irq and node in the error case instead.

Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 17c71bb..5c3e38e 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -224,9 +224,10 @@ struct irq_desc * __ref irq_to_desc_alloc_node(unsigned int irq, int node)
desc = alloc_bootmem_node(NODE_DATA(node), sizeof(*desc));
- printk(KERN_DEBUG " alloc irq_desc for %d on node %d\n", irq, node);
if (!desc) {
- printk(KERN_ERR "can not alloc irq_desc\n");
+ printk(KERN_ERR
+ "can not alloc irq_desc for irq %d on node %d\n",
+ irq, node);
init_one_irq_desc(irq, desc, node);
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at