Re: [PATCH] VMware Balloon driver

From: Dmitry Torokhov
Date: Tue Apr 06 2010 - 13:06:50 EST


On Tue, Apr 06, 2010 at 09:32:47AM -0700, Avi Kivity wrote:
> On 04/06/2010 01:58 AM, Dmitry Torokhov wrote:
> >
> >> Also please explain the applicability of this driver. Will xen use it?
> >> kvm? Out-of-tree code?
> >>
> > The driver is expected to be used on VMware platform - mainly ESX.
> > Originally we tried to converge with KVM and use virtio and
> > stock virtio_balloon driver but Avi mentioned that our code emulating
> > virtqueue was more than balloon code itself and thus using virtio did
> > not make nuch sense.
> >
>
> Yeah. If we wanted commonality, we could make a balloon_core.c that
> contains the common code. IMO that's premature, but perhaps there's

I really not sure if it makes much sense. Ripping out virtdev/virtqueue
from virtio_balloon leaves pretty much nothing.

> some meat there (like suspend/resume support and /proc//sys interface).

We do not need any special suspend/resume support - the freezeable
workqueue is stopped when suspending.

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/