Re: [PATCH v3] OMAP: Fix for bus width which improves SD card's peformance.

From: Nishanth Menon
Date: Tue Apr 06 2010 - 19:40:31 EST

Chikkature Rajashekar, Madhusudhan had written, on 04/06/2010 06:23 PM, the following:

-----Original Message-----
From: Felipe Balbi [mailto:felipe.balbi@xxxxxxxxx]
Sent: Tuesday, April 06, 2010 11:57 AM
To: ext Nishanth Menon
Cc: Balbi Felipe (Nokia-D/Helsinki); Chikkature Rajashekar, Madhusudhan;
me@xxxxxxxxxxxxxxx; 'kishore kadiyala'; 'Vimal Singh'; tony@xxxxxxxxxxx;
S, Venkatraman; linux-omap@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
Lavinen Jarkko (Nokia-D/Helsinki)
Subject: Re: [PATCH v3] OMAP: Fix for bus width which improves SD card's

On Tue, Apr 06, 2010 at 06:55:03PM +0200, ext Nishanth Menon wrote:
some reasons why i love switch statements ;) since I dont expect other
than precisely 4 and 8 (do we expect 5,6,7 - i might be wrong).. but if
it is so, wont the following be better?

switch (mmc_slot(host).wires)
case 8:
mmc->caps |= MMC_CAP_8_BIT_DATA;
/* fall thru*/
case 4:
mmc->caps |= MMC_CAP_4_BIT_DATA;
WARN("bad width");
I like that, but I remember Madhu (or someone else) saying he thinks
it's less readable this way. Go figure...

Well, I did not comment on the usage of switch here. Note we only need to
handle 8-bit and 4-bit.The board files need not setup 8-bit or 4-bit if the
configuration of that board is 1-bit. The driver will still work in 1-bit
mode which would mean there is nothing to do in default case and should not
err out.
check the attachment out.. hope that takes care of it.. just as a reference alone ofcourse..
Nishanth Menon