Re: [PATCH 0/4]-V3 TPS6507x MFD driver

From: Samuel Ortiz
Date: Wed Apr 07 2010 - 04:42:45 EST

Hi Todd,

On Mon, Apr 05, 2010 at 08:23:55PM -0600, Todd Fischer wrote:
> This is the third posting of the TPS6507x driver set. I have
> resolved the concurrent access issue identified by Mark Brown.
> Instead of using a mutex, I used the i2c_transfer() as done in
> the similar routine in the wm8400-core.c file.
> The TPS6507x family of Texas Instruments power management ICs (pmic) are
> multi-function chips that include voltage regulation and touch screen
> controller capabilities. This patch set adds a TPS6507x multi-function
> device driver and change the TPS6507x regulator driver to use the
> TPS6507x MFD driver instead of interacting with the chip directly. The
> changes are needed before a touch screen driver can be added.
> The patch set applies cleanly to the MFD repository:
> git:// If the
> MFD and voltage regulator maintainer would prefer I post patches for a
> different repository, please let me know.
All 4 patches applied to my for-next branch.
Some nit picking advices for your future patches:
- Include the Signed-off-by and Acked-by you collect along the review cycles.
- Have shorter patch subject, they typically are less than 80 chars.
- Describe the changes when moving from patchset vN to patchset vN+1. Also we
prefer "[PATCH vN]" to "[PATCH]-vN", it makes our life easier when applying
your patches.

Thanks a lot for your work.


Intel Open Source Technology Centre
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at