[PATCH 06/12] x86/amd-iommu: enable iommu before attaching devices

From: Joerg Roedel
Date: Wed Apr 07 2010 - 08:49:22 EST

From: Chris Wright <chrisw@xxxxxxxxxxxx>

Hit another kdump problem as reported by Neil Horman. When initializaing
the IOMMU, we attach devices to their domains before the IOMMU is
fully (re)initialized. Attaching a device will issue some important
invalidations. In the context of the newly kexec'd kdump kernel, the
IOMMU may have stale cached data from the original kernel. Because we
do the attach too early, the invalidation commands are placed in the new
command buffer before the IOMMU is updated w/ that buffer. This leaves
the stale entries in the kdump context and can renders device unusable.
Simply enable the IOMMU before we do the attach.

Cc: stable@xxxxxxxxxx
Cc: Neil Horman <nhorman@xxxxxxxxxxxxx>
Cc: Vivek Goyal <vgoyal@xxxxxxxxxx>
Signed-off-by: Chris Wright <chrisw@xxxxxxxxxxxx>
Signed-off-by: Joerg Roedel <joerg.roedel@xxxxxxx>
arch/x86/kernel/amd_iommu_init.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
index feaf471..8975965 100644
--- a/arch/x86/kernel/amd_iommu_init.c
+++ b/arch/x86/kernel/amd_iommu_init.c
@@ -1304,6 +1304,8 @@ static int __init amd_iommu_init(void)
if (ret)
goto free;

+ enable_iommus();
if (iommu_pass_through)
ret = amd_iommu_init_passthrough();
@@ -1316,8 +1318,6 @@ static int __init amd_iommu_init(void)


- enable_iommus();
if (iommu_pass_through)
goto out;

@@ -1331,6 +1331,7 @@ out:
return ret;

+ disable_iommus();



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/