Re: [PATCH] ext4: BUG_ON could be triggered in ext4_mb_normalize_request()

From: jing zhang
Date: Wed Apr 07 2010 - 12:56:50 EST


2010/4/7, tytso@xxxxxxx <tytso@xxxxxxx>:
> On Wed, Apr 07, 2010 at 09:51:46PM +0800, jing zhang wrote:
>> From: Jing Zhang <zj.barak@xxxxxxxxx>
>>
>> Date: Wed Apr 7 21:34:48 2010
>>
>> BUG_ON at [line: 2912] could be triggered,
>> if (pa->pa_deleted == 0 && pa->pa_free == 0)
>> as checked at [line: 3111] and [line: 3122].
>
> Please don't use line numbers, as line numbers may not be the same in
> your version and my version. Secondly, please give a high-level
> scenario where this could happen.
>
> - Ted
>

My duty is not over, and I think, more check seems necessary.

- zj
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/