Re: [WATCHDOG] set max63xx driver as ARM only

[Geert Uytterhoeven]

On Tue, Apr 6, 2010 at 23:59, Linux Kernel Mailing List
<linux-kernel@xxxxxxxxxxxxxxx> wrote:
> Gitweb: Â Â http://git.kernel.org/linus/5e8037166497f8a1aa46325ed7febf0408d45caa
> Commit: Â Â 5e8037166497f8a1aa46325ed7febf0408d45caa
> Parent: Â Â 35c79780064976cf9d7537a00e59f97c2061fa7d
> Author: Â Â Marc Zyngier <maz@xxxxxxxxxxxxxxx>
> AuthorDate: Mon Mar 29 20:09:14 2010 +0100
> Committer: ÂWim Van Sebroeck <wim@xxxxxxxxx>
> CommitDate: Sat Apr 3 22:39:30 2010 +0000
>
> Â Â[WATCHDOG] set max63xx driver as ARM only
>
> Â ÂUse of ioremap() causes build failure on S390.
> Â ÂRestrict the driver to ARM until another architecture comes along
> Â Âand enables the driver for its own use.
>
> Â ÂSigned-off-by: Marc Zyngier <maz@xxxxxxxxxxxxxxx>
> Â ÂSigned-off-by: Wim Van Sebroeck <wim@xxxxxxxxx>
> Â ÂSigned-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> Âdrivers/watchdog/Kconfig | Â 11 ++++++-----
> Â1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index bdcdbd5..0e8468f 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -55,11 +55,6 @@ config SOFT_WATCHDOG
> Â Â Â Â ÂTo compile this driver as a module, choose M here: the
> Â Â Â Â Âmodule will be called softdog.
>
> -config MAX63XX_WATCHDOG
> - Â Â Â tristate "Max63xx watchdog"
> - Â Â Â help
> - Â Â Â Â Support for memory mapped max63{69,70,71,72,73,74} watchdog timer.
> -
> Âconfig WM831X_WATCHDOG
> Â Â Â Âtristate "WM831x watchdog"
> Â Â Â Âdepends on MFD_WM831X
> @@ -305,6 +300,12 @@ config TS72XX_WATCHDOG
> Â Â Â Â ÂTo compile this driver as a module, choose M here: the
> Â Â Â Â Âmodule will be called ts72xx_wdt.
>
> +config MAX63XX_WATCHDOG
> + Â Â Â tristate "Max63xx watchdog"
> + Â Â Â depends on ARM

Shouldn't that have been `depends on HAS_IOMEM' instead?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/