Re: [PATCH 2/2] ia64: ptrace_attach_sync_user_rbs: avoid "task->signal!= NULL" checks

From: Roland McGrath
Date: Wed Apr 07 2010 - 21:55:15 EST


Acked-by: Roland McGrath <roland@xxxxxxxxxx>

> Note: this code doesn't need this check and tasklist_lock at all,
> it should be converted to use lock_task_sighand(). And, the code
> under SIGNAL_STOP_STOPPED check looks wrong.

Agreed. It should match that part of ptrace_untrace().


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/