Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmas of a mergeable VMA
From: KOSAKI Motohiro
Date: Wed Apr 07 2010 - 22:03:47 EST
Wow, your patch is very cool. I'm surprising such 20 lines patch makes
> On Wed, 7 Apr 2010, Linus Torvalds wrote:
> > Yes. The failure point is too late to do anything really interesting with,
> > and the old code also just causes a SIGBUS. My intention was to change the
> > WARN_ONCE(!vma->anon_vma);
> > into returning that SIGBUS - which is not wonderful, but is no different
> > from old failures.
> Not SIGBUS, but VM_FAULT_OOM, of course.
Now pagefault don't insert anon_vma anymore, right? if so, SIGBUS is better.
Now SIGBUS and VM_FAULT_OOM make different result.
SIGBUS -> kill current task
VM_FAULT_OOM -> invoke oom-killer (see pagefault_out_of_memory())
If current task can't recover proper anon_vma. we should just kill current
instead random highest badness process. otherwise !anon_vma process continue
to randomly invoke oom-killer.
Perhaps, I'm missing something.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/