Re: [PATCH] random: Forbid llseek on random chardev

[Arnd Bergmann]

On Saturday 10 April 2010 18:35:30 Frederic Weisbecker wrote:
> 
> > > Using generic_file_llseek means we no longer need to
> > > take the BKL if anyone tries to seek on these.
> > 
> > Comment doesn't match the patch?

Yes, my fault. The version in my series already had this problem.

> Oops. I guess the patch has been updated, but not the changelog.
> 
> Some background: we are trying to remove the uses of default_llseek
> that use the bkl. We started with turning llseek stubs to
> generic_file_llseek (or non seekable open in some cases), but we are
> hesitating now and think about actually turn all the stubs that
> might need the bkl into default_llseek, and fallback to
> generic_file_llseek for all other stubs.
> 
> Depending on what we do I'll resend you an updated version
> of this patch with generic_file_llseek, or I will let the stub
> as is.

The noop_llseek from Jan's series seems most appropriate here.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/