Re: [PATCH 04/12] frv: remove "struct file *" argument from sysctl ->proc_handler

[Jan Blunck]

On Fri, Apr 09, Alexey Dobriyan wrote:

> On Fri, Apr 9, 2010 at 5:00 PM, Jan Blunck <jblunck@xxxxxxx> wrote:
> > Seems that Alexey Dobriyan missed this usage of the file argument when
> > removing it from ->proc_handler in commit 8d65af789f3e2cf4cfbdbf71a0f7a61ebcd41d38.
> 
> It wasn't missed, it was deliberately left out because I didn't understand
> what's going on there.
> 
> I mean, sysctl handler touching ->f_pos, come on!
> 
> What's going on?
> 

It is just a normal /proc/sys file. You can write a string to it to change the
some caching mode somehow.

Jan

> > --- a/arch/frv/kernel/sysctl.c
> > +++ b/arch/frv/kernel/sysctl.c
> > @@ -85,7 +86,7 @@ static int procctl_frv_cachemode(ctl_table *table, int write, struct file *filp,
> >        }
> >
> >        /* read the state */
> > -       if (filp->f_pos > 0) {
> > +       if (*ppos > 0) {
> >                *lenp = 0;
> >                return 0;
> >        }
Regards,
	Jan

-- 
Jan Blunck <jblunck@xxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/