Re: [PATCH] AT91: at91sam9g10 chip identification changed

[Andrew Victor]

hi Nicolas,

> A bit in the at91sam9g10 identification number changed between Engineering
> Sample and final product. This patch will identify both as being at91sam9g10.

> -#define ARCH_ID_AT91SAM9G10    0x819903a0
> +#define ARCH_ID_AT91SAM9G10    0x019903a0

> -#define cpu_is_at91sam9g10()   (at91_cpu_identify() == ARCH_ID_AT91SAM9G10)
> +#define cpu_is_at91sam9g10()   ((at91_cpu_identify() & ~AT91_CIDR_EXT) == ARCH_ID_AT91SAM9G10)


Wouldn't it be better to just mask out the AT91_CIDR_EXT bit in
at91_cpu_identify()?
That bit isn't really useful for "version" information.

We'd then just need to modify:
  #define ARCH_ID_AT91SAM9G10          0x019903a0
  #define ARCH_ID_AT91SAM9G45          0x019b05a0
  #define ARCH_ID_AT91SAM9G45MRL  0x019b05a2      /* aka 9G45-ES2 &
non ES lots */
  #define ARCH_ID_AT91SAM9G45ES     0x019b05a1      /* 9G45-ES
(Engineering Sample) */
(ie, drop bit AT91_CIDR_EXT)


Regards,
  Andrew Victor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/