Re: [PATCH 3/6] change alloc function in alloc_slab_page

[Minchan Kim]

On Wed, Apr 14, 2010 at 12:52 AM, Mel Gorman <mel@xxxxxxxxx> wrote:
> On Wed, Apr 14, 2010 at 12:25:00AM +0900, Minchan Kim wrote:
>> alloc_slab_page never calls alloc_pages_node with -1.
>
> Are you certain? What about
>
> __kmalloc
> Â-> slab_alloc (passed -1 as a node from __kmalloc)
> Â Â-> __slab_alloc
> Â Â Â-> new_slab
> Â Â Â Â-> allocate_slab
> Â Â Â Â Â-> alloc_slab_page
>

Sorry for writing confusing changelog.

I means if node == -1 alloc_slab_page always calls alloc_pages.
So we don't need redundant check.

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/