Re: [PATCH 5/6] ceph: refactor mount related functions, add helpers

[Andi Kleen]

Yehuda Sadeh <yehuda@xxxxxxxxxxxxxxx> writes:
>  
> +int ceph_copy_to_page_vector(struct page **pages,
> +				    const char *data,
> +				    loff_t off, size_t len)
> +{
> +	int i = 0;
> +	int po = off & ~PAGE_CACHE_MASK;
> +	int left = len;
> +	int l;
> +
> +	while (left > 0) {
> +		l = min_t(int, PAGE_CACHE_SIZE-po, left);

int seems like exactly the wrong type here.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/