Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages

From: Minchan Kim
Date: Thu Apr 15 2010 - 07:49:38 EST


On Thu, Apr 15, 2010 at 8:43 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> Hello,
>
> On 04/15/2010 07:21 PM, Minchan Kim wrote:
>> kill alloc_pages_exact_node?
>> Sorry but I can't understand your point.
>> I don't want to kill user of alloc_pages_exact_node.
>> That's opposite.
>> I want to kill user of alloc_pages_node and change it with
>> alloc_pages_any_node or alloc_pages_exact_node. :)
>
> I see, so...
>
> Âalloc_pages() Â Â Â Â Â-> alloc_pages_any_node()
> Âalloc_pages_node() Â Â -> alloc_pages_exact_node()
>
> right? ÂIt just seems strange to me and different from usual naming
> convention - ie. something which doesn't care about nodes usually
> doesn't carry _node postfix. ÂAnyways, no big deal, those names just
> felt a bit strange to me.

I don't want to remove alloc_pages for UMA system.
#define alloc_pages alloc_page_sexact_node

What I want to remove is just alloc_pages_node. :)
Sorry for confusing you.

--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/