Re: mmotm 2010-04-15-14-42 uploaded (shmem, CGROUP_MEM_RES_CTLR)

From: Randy Dunlap
Date: Fri Apr 16 2010 - 12:03:53 EST


On Thu, 15 Apr 2010 14:42:59 -0700 akpm@xxxxxxxxxxxxxxxxxxxx wrote:

> The mm-of-the-moment snapshot 2010-04-15-14-42 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
>
> and will soon be available at
>
> git://zen-kernel.org/kernel/mmotm.git
>
> It contains the following patches against 2.6.34-rc4:


memcg-move-charge-of-file-pages.patch:

when CONFIG_SHMFS is not enabled:

mm/shmem.c:2721: error: implicit declaration of function 'SHMEM_I'
mm/shmem.c:2721: warning: initialization makes pointer from integer without a cast
mm/shmem.c:2726: error: dereferencing pointer to incomplete type
mm/shmem.c:2727: error: implicit declaration of function 'shmem_swp_entry'
mm/shmem.c:2727: warning: assignment makes pointer from integer without a cast
mm/shmem.c:2734: error: implicit declaration of function 'shmem_swp_unmap'
mm/shmem.c:2735: error: dereferencing pointer to incomplete type


However, adding (needed)
#include <linux/spinlock.h>
to that source file does not fix the build error.

Should CGROUP_MEM_RES_CTLR depend on SHMFS or anything else?


kernel config attached.

thanks,
---
~Randy

Attachment: config-r9857
Description: Binary data