Re: [PATCHv5 2.6.34-rc4 4/5] mxc: Add generic USB HW initialization for MX51

[Grant Likely]

On Mon, Apr 19, 2010 at 7:13 PM, Daniel Mack <daniel@xxxxxxxx> wrote:
> On Mon, Apr 19, 2010 at 05:27:03PM -0500, Dinh.Nguyen@xxxxxxxxxxxxx wrote:
>> +             /* allow controller to reset, and leave time for
>> +              * the ULPI transceiver to reset too.
>> +              */
>> +             msleep(100);
>
> Does the sleep really need to be that long? You're holding off the
> kernel's by that. If we can reduce that, we should certainly do so.

msleep() should be fine since Linux will schedule something else.
mdelay(100) would be bad indeed.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/