Re: [PATCH] Fix regression in O_DIRECT|O_SYNC writes to blockdevices

From: Anton Blanchard
Date: Mon Apr 19 2010 - 22:30:26 EST



Hi,

> Actually you can just drop this call entirely. sync_blockdev is an
> overcomplicated alias for filemap_write_and_wait on the block device
> inode, which is exactl what we did just before calling into ->fsync
>
> It might be worth to still drop i_mutex for the cache flush, though.

Thanks for the feedback Jan + Christoph. New patch on the way.

Anton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/