Re: pci_get_dev_by_id() from interrupt handlers

From: Joerg Roedel
Date: Wed Apr 21 2010 - 06:41:54 EST


On Wed, Apr 21, 2010 at 12:21:11PM +0200, Peter Zijlstra wrote:
> On Wed, 2010-04-21 at 12:05 +0200, Joerg Roedel wrote:
> >
> > > Why not do the whole thing in an interrupt task as the whole thing
> > > sounds like something that shouldn't be done in interrupt context,
> > > right? Now that we have this type of functionality, we should take
> > > advantage of it :)
> >
> > Ok, I think I move the IOMMU interrupt handling to a tasklet.
> >
> tasklet is softirq context, and is not what gregkh was talking about.
>
> You'd still need to change the klist spinlock to be softirq-safe.

Ah right. Thanks for pointing this out. I couldn't find much about the
interrupt tasks. Is it about the request_threaded_irq interface? And
this would be run in the context of a kernel thread, right?

Joerg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/