Re: [PATCH 3/3] p9auth: add p9auth driver

From: David Howells
Date: Wed Apr 21 2010 - 06:50:26 EST


Serge E. Hallyn <serue@xxxxxxxxxx> wrote:

> + if (ret == 0)
> + commit_creds(new);
> + else
> + abort_creds(new);
> +
> + return ret;

If you make this:

if (ret == 0)
return commit_creds(new);
abort_creds(new);
return ret;

then gcc can tail-call commit_creds(), which is guaranteed to return 0.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/