Re: [PATCH 3/3] x86,pci,acpi: Handle invalid _CRS

[Yinghai Lu]

On 04/21/2010 08:21 AM, Bjorn Helgaas wrote:
>
>
>> +	if (pci_use_crs)
>> +		pci_bus_remove_resources(bus);
>> +
>>  	info.res_num = 0;
>>  	acpi_walk_resources(device->handle, METHOD_NAME__CRS, setup_resource,
>>  				&info);
>>  
>> +	if (pci_use_crs && !info.res_num) {
>> +		/* Restore default one */
>> +		bus->resource[0] = &ioport_resource;
>> +		bus->resource[1] = &iomem_resource;
>>     
> This is ugly because it just repeats this code from pci_create_bus(),
> and there's no indication either here or there that they are connected.
>
> Admittedly, I think it's also sort of ugly that pci_bus_remove_resources()
> exists at all -- I'd rather have some sort of hook so we could set the
> bus resources correctly the first time.
>   
sure. that would be better. Can you have patch for that.
> Maybe you could at least add a pci_bus_set_default_resources() that
> could be called both here and from pci_create_bus().
>   
good idea.
> Why are you doing this patch?  Did you see a machine where the host
> bridge was left with no resources because of _CRS issues?  If so,
> this patch feels like a band-aid.  I'd rather investigate the issue
> directly, because that would probably be a Linux problem we could fix.
>
> Also, if there *is* a reported problem, you should include a link to
> the bugzilla or email thread.
>   
No, just code review.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/