Re: [PATCH] kbuild: add *.rej pattern to .gitignore

From: Michal Marek
Date: Wed Apr 21 2010 - 16:22:23 EST


On 21.4.2010 18:33, AmÃrico Wang wrote:
> On Wed, Apr 21, 2010 at 05:31:34PM +0200, Guennadi Liakhovetski wrote:
>> On Wed, 21 Apr 2010, AmÃÂrico Wang wrote:
>>> On Wed, Apr 21, 2010 at 01:47:29PM +0200, Guennadi Liakhovetski wrote:
>>>> Tell git to ignore .rej files, generated by patch(1).
>>>>
>>>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
>>> NACK.
>>>
>>> You have to handle *.rej files, not leaving them there.
>> Hm? I know I have to handle them, and I do handle them, but IMHO it's
>> entirely valid and up to the user to leave them where they are. You could
>> apply similar argument to *.orig or to *~ files. In other words, I'm not
>> convinced.
>>
>
> I am not the only people who is against this, there
> was a discussion about this before, please search lkml
> archive.

...and there is no point in starting the flamewar again. If you want to
ignore *.rej files, which is a perfectly valid personal preference, I
suggeest you add the pattern to .git/info/exclude.

hth,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/