Re: [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec.

[Andrew Morton]

On Fri,  9 Apr 2010 14:21:27 +0000
Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx> wrote:

> From: Peter Jones <pjones@xxxxxxxxxx>
> 
> - Use struct acpi_table_ibft instead of struct ibft_table_header
> - Don't do reserve_ibft_region() on UEFI machines (section 1.4.3.1)
> - If ibft_addr isn't initialized when ibft_init() is called, check for
>   ACPI-based tables.
> 
> Author:      Peter Jones <pjones@xxxxxxxxxx>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>
> Reviewed-by: Mike Christie <michaelc@xxxxxxxxxxx>

This should have Peter's Signed-off-by:, please.

>
> ...
>
> +#ifdef CONFIG_ACPI
> +static int __init acpi_find_ibft(struct acpi_table_header *header)
> +{
> +	ibft_addr = (struct acpi_table_ibft *)header;

container_of() would be better here.  And maybe elsewhere, too.

> +	return 0;
> +}
> +#endif /* CONFIG_ACPI */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/