Re: [PATCH 1/2] Make WMI be selected automatically when needed

[Éric Piel]

Op 23-04-10 21:20, Matthew Garrett schreef:
> On Sat, Apr 17, 2010 at 02:58:29AM +0200, Éric Piel wrote:
> 
>>  config LEDS_DELL_NETBOOKS
>>  	tristate "External LED on Dell Business Netbooks"
>> -	depends on X86 && ACPI_WMI
>> +	depends on X86
>> +	depends on ACPI
>> +	select ACPI_WMI
> 
> I dislike this. The originally stated dependencies are correct and more 
> accurately represent what the code requires, and changing that for the 
> sake of making it easier for people to find the driver sounds like it's 
> trying to cover up shortcomings in our configuration system more than 
> anything else.
> 
Currently there are 2 modules which select ACPI_WMI and 4 which depend
on it. There are 7 modules which select BACKLIGHT_CLASS_DEVICE and as
many which depend on it. Making usage of the select functionality all
the time would avoid these inconsistencies.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/