Re: [PATCH 10/11] viafb: rework the I2C support in the VIAframebuffer driver

From: Jonathan Corbet
Date: Fri Apr 23 2010 - 17:57:36 EST


On Fri, 23 Apr 2010 23:12:54 +0200
Florian Tobias Schandinat <FlorianSchandinat@xxxxxx> wrote:

> 1. while the module loads the screen shows some strange colours. The
> colours itself do not worry me but it probably at least means that the
> module load time was increased significantly (2-3 seconds, I guess)
>
> 2. most annoyingly after this patch I can no longer get a working VGA
> console after unbinding the module. Normally I just do:

Hmm...compiling the driver as a module is not really something that
makes sense on the OLPC platform, so I've never done it.

#1 is weird, there should be nothing there that slows initialization
down. Putting in some prints and looking at the timing would be most
helpful here.

As for #2, I can certainly say that I've never unloaded this code, so
that's an untested path. I'll have a look and see if I can see
anything obvious.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/