Re: HID: expand hid-topseed driver to support BTC "Emprex 3009URFIII Vista MCE Remote"

From: Jiri Kosina
Date: Wed Apr 28 2010 - 07:51:30 EST


On Wed, 28 Apr 2010, Wayne Thomas wrote:

> >> OK, next attempt...
> >
> > The patch is OK, but your mail client whitespace-damaged it. Could you
> > please fix up your client and resend? (or attach it separately as an
> > attachment, if your client can't be fixed).
> >
> > Thanks,
>
> I thought it might have; sorry about that.
> Have attached patch as separate file as a precaution.

Thanks for the patch.

What is the reason for it being backwards-compatible with the older
topspeed device?

Changes such as

- case 0x048: ts_map_key_clear(KEY_RED); break;
+ case 0x05b: ts_map_key_clear(KEY_RED); break;

(and no other handling of neither 0x048 nor KEY_RED) make me wonder ...

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/