Re: [v4 Patch 1/3] netpoll: add generic support for bridge and bondingdevices

[Cong Wang]

Dongdong Deng wrote:
> +             if (ops->ndo_netpoll_cleanup)
> +                                       ops->ndo_netpoll_cleanup(np->dev);
> +             np->dev->npinfo = NULL;
>
> I think it is good to set np->dev->npinfo to NULL  even though we have
> the netpoll_cleanup opt.

This is redundant, since ->ndo_netpoll_cleanup will set it.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/