Re: [PATCH 3/5] PM / Hibernate: separate block_io

[Pavel Machek]

Hi!

> Move block I/O operations to a separate file. It is because it will
> be used later not only by the swap writer.
> 
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Nigel Cunningham <ncunningham@xxxxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rjw@xxxxxxx>

> +++ b/kernel/power/block_io.c
> @@ -0,0 +1,103 @@
> +/*
> + * This file provides functions for block I/O operations on swap/file.
> + *
> + * Copyright (C) 1998,2001-2005 Pavel Machek <pavel@xxxxxxx>

That address no longer works, but keeps popping up....

> diff --git a/kernel/power/power.h b/kernel/power/power.h
> index b1e207d..006270f 100644
> --- a/kernel/power/power.h
> +++ b/kernel/power/power.h
> @@ -142,6 +142,15 @@ extern int swsusp_read(unsigned int *flags_p);
>  extern int swsusp_write(unsigned int flags);
>  extern void swsusp_close(fmode_t);
>  
> +/* kernel/power/block_io.c */
> +extern struct block_device *hib_resume_bdev;

It is slightly sad that this is now not only static, but also
cross-module...


> +extern int hib_bio_read_page(pgoff_t page_off, void *addr,
> +		struct bio **bio_chain);
> +extern int hib_bio_write_page(pgoff_t page_off, void *addr,
> +		struct bio **bio_chain);
> +extern int hib_wait_on_bio_chain(struct bio **bio_chain);
> +

Does the documentation usually go to the header in these cases?

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/