Re: [PATCH 0/5] perf inject + say no to __KERNEL__ only stuff

From: Ingo Molnar
Date: Mon May 03 2010 - 03:38:17 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

>
> * H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>
> > On 05/02/2010 11:24 PM, Ingo Molnar wrote:
> > >
> > > Pulled, thanks a lot!
> > >
> >
> > With this, core/hweight should work properly, I hope.
>
> Ok, i merged that too - will let you know about any trouble.

It broke half of the non-x86 architectures. For example on Sparc defconfig:

In file included from /home/mingo/tip/include/asm-generic/bitops/hweight.h:4,
from /home/mingo/tip/arch/sparc/include/asm/bitops_32.h:103,
from /home/mingo/tip/arch/sparc/include/asm/bitops.h:6,
from /home/mingo/tip/include/linux/bitops.h:17,
from /home/mingo/tip/include/linux/kernel.h:15,
from /home/mingo/tip/include/linux/sched.h:54,
from /home/mingo/tip/arch/sparc/kernel/asm-offsets.c:13:
/home/mingo/tip/include/asm-generic/bitops/arch_hweight.h: In function '__arch_hweight32':
/home/mingo/tip/include/asm-generic/bitops/arch_hweight.h:8: error: implicit declaration of function '__sw_hweight32'
/home/mingo/tip/include/asm-generic/bitops/arch_hweight.h: In function '__arch_hweight16':
/home/mingo/tip/include/asm-generic/bitops/arch_hweight.h:13: error: implicit declaration of function '__sw_hweight16'
/home/mingo/tip/include/asm-generic/bitops/arch_hweight.h: In function '__arch_hweight8':
/home/mingo/tip/include/asm-generic/bitops/arch_hweight.h:18: error: implicit declaration of function '__sw_hweight8'
/home/mingo/tip/include/asm-generic/bitops/arch_hweight.h: In function '__arch_hweight64':
/home/mingo/tip/include/asm-generic/bitops/arch_hweight.h:23: error: implicit declaration of function '__sw_hweight64'

(the failure on other architectures looks similar)

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/