Re: [PATCH] ixgb and e1000: Use new function for copybreak tests

From: Jeff Kirsher
Date: Mon May 03 2010 - 16:44:17 EST


On Sun, May 2, 2010 at 17:46, Joe Perches <joe@xxxxxxxxxxx> wrote:
> There appears to be an off-by-1 defect in the maximum packet size
> copied when copybreak is speified in these modules.
>
> The copybreak module params are specified as:
> "Maximum size of packet that is copied to a new buffer on receive"
>
> The tests are changed from "< copybreak" to "<= copybreak"
> and moved into new static functions for readability.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> Âdrivers/net/e1000/e1000_main.c | Â 47 ++++++++++++++++++++---------------
> Âdrivers/net/ixgb/ixgb_main.c  |  52 +++++++++++++++++++++++----------------
> Â2 files changed, 58 insertions(+), 41 deletions(-)
>

Thanks Joe, I have added the patch to my queue of patches.

--
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/