Re: [PATCH] drivers: staging: GPS protocol driver for wl128x

[Alan Cox]

On Tue, 4 May 2010 21:55:43 +0530 (IST)
Pavan Savoy <pavan_savoy@xxxxxx> wrote:

> Greg, Alan,
> 
> Just to complete the circle on N_TI_WL, find below the GPS driver which makes use of the shared transport line discipline.
> 
> This driver provides a TTY line character device to application/middle-ware running on host, as if the device is directly connected over UART to a GPS chip.

This doesn't appear to be a tty device ?

> Almost all actions that can be done on a /dev/ttySx can be done on this /dev/tigps device.

Hardly true. A tty driver has a very precisely defined set of behaviours
and a lot of ioctls and interfaces your driver doesn't. Our gps
interfaces are only tty drivers because historically they were plugged
into serial ports so I'm not sure the 'not a tty' bit actually matters.

Codewise its the same as all the rest - only one instance possible and
poking around in globals with no visible or documented locking.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/