Re: [PATCH 1/2] KVM MMU: fix for forgot mark parent->unsync_childrenbit

[Xiao Guangrong]

Avi Kivity wrote:
> On 05/05/2010 03:19 PM, Xiao Guangrong wrote:
>> When mapping a new parent to unsync shadow page, we should mark
>> parent's unsync_children bit
>>
>> Reported-by: Marcelo Tosatti<mtosatti@xxxxxxxxxx>
>> Signed-off-by: Xiao Guangrong<xiaoguangrong@xxxxxxxxxxxxxx>
>> ---
>>   arch/x86/kvm/mmu.c |    4 +++-
>>   1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
>> index 97f2ea0..bf35a2f 100644
>> --- a/arch/x86/kvm/mmu.c
>> +++ b/arch/x86/kvm/mmu.c
>> @@ -1374,7 +1374,9 @@ static struct kvm_mmu_page
>> *kvm_mmu_get_page(struct kvm_vcpu *vcpu,
>>               if (sp->unsync_children) {
>>                   set_bit(KVM_REQ_MMU_SYNC,&vcpu->requests);
>>                   kvm_mmu_mark_parents_unsync(sp);
>> -            }
>> +            } else if (sp->unsync)
>> +                kvm_mmu_mark_parents_unsync(sp);
>> +
>>               trace_kvm_mmu_get_page(sp, false);
>>               return sp;
>>           }
>>    
> 
> 
> Which patch does this fix?  If it wasn't merge yet, please repost with
> the fix included.

Oh, OK, i'll sent the previous pathset that are reverted by Marcelo.

Thanks,
Xiao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/