Re: [PATCH] ad7877: fix spi word size to 16 bit

[Daniel GlÃckner]

On 05/06/2010 08:26 PM, Mike Frysinger wrote:
> i think it'd be a better idea to do something like:
>   if (spi->bits_per_word != 16) {
>     if (spi->bits_per_word) {
>       dev_err(&spi->dev, "Invalid SPI settings; bits_per_word must be 16\n");
>       return -EINVAL;
>     }
>     spi->bits_per_word = 16;
>     spi_setup(spi);
>   }

There is no way to set bits_per_word using struct spi_board_info. The
description of that structure in spi.h explicitly lists the wordsize as
one of the parameters drivers should set themself in probe().

Only struct bfin5xx_spi_chip allows to set this value in the board code.

  Daniel


-- 
Dipl.-Math. Daniel GlÃckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax -11, Bahnhofsallee 1b, 37081 GÃttingen, Germany
Sitz der Gesellschaft: GÃttingen, Amtsgericht GÃttingen HR B 3160
GeschÃftsfÃhrer: Dr. Uwe Kracke, Ust-IdNr.: DE 205 198 055

emlix - your embedded linux partner
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/