Re: [PATCH] drivers: staging: dream: fix smd in makefile

From: Greg KH
Date: Fri May 07 2010 - 13:09:51 EST


On Thu, May 06, 2010 at 05:00:01PM -0700, Daniel Walker wrote:
> On Thu, 2010-05-06 at 16:54 -0700, Greg KH wrote:
> > On Thu, May 06, 2010 at 04:48:59PM -0700, Daniel Walker wrote:
> > > Not sure about this one.. Cause if you apply this then some SMD files
> > > don't compile anymore. There's some missing config options related to
> > > AMSS.
> > >
> > > NOT-Signed-off-by: Daniel Walker <dwalker@xxxxxxxxxxxxxx>
> >
> > Heh, I'm not going to apply this then :)
> >
> > > CC: Greg KH <greg@xxxxxxxxx>
> > > Cc: Pavel Machek <pavel@xxxxxx>
> > > ---
> > > drivers/staging/dream/Makefile | 3 ++-
> >
> > With the recent progression of your arch tree, and the
> > wakelock/suspend-blocker stuff, what's the need for these files to still
> > be in the staging directory at all? Can't it be deleted and it go
> > through your tree?
>
> Yeah, all the smd stuff can .. The rest of it should stay for now I
> think. I'm not ready to take on those other specific drivers, like the
> camera etc..
>
> Should I just send a patch to drop the whole SMD directory then?

Yes, I think so. Pavel, any objections?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/