Re: [PATCH 2/2] mm,migration: Fix race between shift_arg_pages andrmap_walk by guaranteeing rmap_walk finds PTEs created within the temporarystack

From: Linus Torvalds
Date: Sun May 09 2010 - 21:35:56 EST




On Sun, 9 May 2010, Linus Torvalds wrote:
>
> So I never disliked that patch. I'm perfectly happy with a "don't migrate
> these pages at all, because they are in a half-way state in the middle of
> execve stack magic".

Btw, I also think that Mel's patch could be made a lot _less_ magic by
just marking that initial stack vma with a VM_STACK_INCOMPLETE_SETUP bit,
instead of doing that "maybe_stack" thing. We could easily make that
initial vma setup very explicit indeed, and then just clear that bit when
we've moved the stack to its final position.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/